fix(warehouse-sources): align MCP tool scopes with the API by webjunkie · Pull Request #111842 · PostHog/posthog

webjunkie · 2026-10-05T11:50:59Z

Title: fix(warehouse-sources): align MCP tool scopes with the API

Problem

The two destinations retrieve MCP tools (source and schema) listed external_data_source:read. The destinations action serves both GET and PATCH, so it sits in scope_object_write_actions and requires :write even for a read. A read-only token saw the tools and got a 403.

Pairs with the coverage warning from #111811.

Changes

Tool scopes now list external_data_source:write, which is what the endpoint enforces today.
required_scopes in the generated tool definitions updated to match.

Follow-up for the owning team: splitting GET from PATCH (for example with dangerously_get_required_scopes keyed on the HTTP method) would let read-only tokens use these tools. That is a runtime access change, so it is left out here.

How did you test this code?

Read the viewset scope lists and APIScopePermission._get_required_scopes.

Test rationale: No test added. This is MCP tool metadata, no backend code changed. The generated schema JSON was edited by hand for the touched tools because the local OpenAPI spec was stale and a full regenerate rewrote unrelated files. The scope coverage warning from #111811 is the check for this class of drift.

Release status

No feature flag controls this change

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Sonnet 5.5 (claude-sonnet-5-5) subagent, orchestrated by Claude Opus 5.5 (claude-opus-5-5)

Scopes were checked by reading the permission path in APIScopePermission._get_required_scopes and the viewset declarations, not only the OpenAPI spec. No duplicate PR search was run.

The destinations action serves both GET and PATCH, so it sits in scope_object_write_actions on the source and schema viewsets and requires external_data_source:write even for a read. The two retrieve tools listed :read, so a read-only token saw them and then got a 403. Pairs with the MCP scope coverage warning in codegen.

trunk-io · 2026-10-05T11:51:03Z

😎 Merged successfully - details.

posthog · 2026-10-05T11:51:05Z

FLASH MODE - Faster, but stupid, use regular ReviewHog for a heavy review

🦔 PostHog Review reviewed this pull request

Nothing worth raising this time. Enjoy the moment:

github-actions · 2026-10-05T11:52:54Z

🤖 CI report

⚠️

Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

✅ Bundle size — no change

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 69.51 MiB · no change

No file changed by more than 1000 B.

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) `src/index.tsx`	1.63 MiB · 23 files	no change	`█████████░` 88.6% of 1.84 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) `src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts`	3.71 MiB · 663 files	no change	`█████████░` 92.2% of 4.03 MiB
authenticated shell (every logged-in page) `src/scenes/AuthenticatedShell.tsx`	7.61 MiB · 2,415 files	no change	`█████████░` 91.3% of 8.34 MiB
dashboard scene `src/scenes/dashboard/Dashboard.tsx`	9.70 MiB · 3,446 files	no change	`███████░░░` 72.0% of 13.48 MiB
today home path `src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx`	7.62 MiB · 2,423 files	no change	`█████████░` 88.8% of 8.58 MiB
events scene `src/scenes/activity/explore/EventsScene.tsx`	9.32 MiB · 3,298 files	no change	`███████░░░` 73.7% of 12.64 MiB
replay detail scene `src/scenes/session-recordings/detail/SessionRecordingDetail.tsx`	12.13 MiB · 4,142 files	no change	`████████░░` 77.2% of 15.72 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
24.6 KiB	`../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js`
6.3 KiB	`../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js`
4.5 KiB	`../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js`
3.9 KiB	`../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js`
1.4 KiB	`../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js`
1.3 KiB	`src/index.tsx`
1.3 KiB	`src/RootErrorBoundary.tsx`
912 B	`../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js`
839 B	`src/scenes/ChunkLoadErrorBoundary.tsx`

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
99.7 KiB	`src/lib/api.ts`
90.2 KiB	`src/products.tsx`
69.4 KiB	`src/lib/lemon-ui/icons/icons.tsx`
40.4 KiB	`src/lib/utils/eventUsageLogic.ts`
38.7 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
33.9 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
29.0 KiB	`../node_modules/.pnpm/zod@4.3.6/node_modules/zod/v4/core/schemas.js`

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
280.3 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
112.1 KiB	`../packages/quill/packages/quill/dist/index.js`
99.7 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
90.2 KiB	`src/products.tsx`

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
280.3 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
112.1 KiB	`../packages/quill/packages/quill/dist/index.js`
99.7 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`

Largest files eagerly shipped from

src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
280.3 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
112.1 KiB	`../packages/quill/packages/quill/dist/index.js`
99.7 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
90.2 KiB	`src/products.tsx`

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
280.3 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
112.1 KiB	`../packages/quill/packages/quill/dist/index.js`
99.7 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
280.3 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
220.3 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
112.1 KiB	`../packages/quill/packages/quill/dist/index.js`
99.7 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Toolbar bundle — eager 2.21 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.21 MiB · 19 files	no change	`████░░░░░░` 38.6% of 5.72 MiB
Deferred (lazy)	2.11 MiB · 44 files	no change	n/a — loads on demand
Loader `dist/toolbar.js`	1.2 KiB	no change	`█░░░░░░░░░` 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
843.7 KiB	`dist/toolbar/toolbar-app-7WP5DJ5V.css`
657.1 KiB	`dist/toolbar/chunk-chunk-ANDLGWTP.js`
259.4 KiB	`dist/toolbar/chunk-chunk-6KW5GTW2.js`
138.2 KiB	`dist/toolbar/chunk-chunk-TELGYDIR.js`
131.8 KiB	`dist/toolbar/chunk-chunk-FDH2IBXT.js`
75.2 KiB	`dist/toolbar/toolbar-app-CPK5ZUBF.js`
69.0 KiB	`dist/toolbar/chunk-chunk-TSAL54PB.js`
35.6 KiB	`dist/toolbar/chunk-chunk-K5C4YQSL.js`
21.0 KiB	`dist/toolbar/chunk-chunk-ZAZMQ4LE.js`
6.8 KiB	`dist/toolbar/chunk-chunk-DV7IWQNF.js`

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — no change

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 960.66 MiB · no change

ℹ️ MCP UI apps size — 32 app(s), 17180.5 KB JS

Built size of each MCP UI app (main.js + styles.css).

App	JS	CSS
debug	597.9 KB	199.4 KB
action	454.1 KB	199.4 KB
action-list	564.2 KB	199.4 KB
cohort	453.1 KB	199.4 KB
cohort-list	563.2 KB	199.4 KB
email-template	452.9 KB	199.4 KB
error-details	469.6 KB	199.4 KB
error-issue	454.5 KB	199.4 KB
error-issue-list	564.8 KB	199.4 KB
experiment	561.3 KB	199.4 KB
experiment-list	564.9 KB	199.4 KB
experiment-results	566.3 KB	199.4 KB
feature-flag	566.8 KB	199.4 KB
feature-flag-list	570.5 KB	199.4 KB
feature-flag-testing	457.3 KB	199.4 KB
inline-scan	453.6 KB	199.4 KB
insight-actors	562.3 KB	199.4 KB
llm-costs	559.3 KB	199.4 KB
session-recording	455.3 KB	199.4 KB
survey	454.7 KB	199.4 KB
survey-global-stats	561.9 KB	199.4 KB
survey-list	564.9 KB	199.4 KB
survey-stats	561.9 KB	199.4 KB
trace-span	453.5 KB	199.4 KB
trace-span-list	564.1 KB	199.4 KB
vision-observation-list	563.3 KB	199.4 KB
workflow	453.4 KB	199.4 KB
workflow-list	563.5 KB	199.4 KB
loops-review	457.8 KB	199.4 KB
query-results	774.3 KB	199.4 KB
render-ui	857.6 KB	199.4 KB
visual-review-snapshots	457.9 KB	199.4 KB

coderabbitai · 2026-10-05T12:03:17Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 1de93c99-19b0-4bad-8dee-fb622c1162dc

📥 Commits

Reviewing files that changed from the base of the PR and between ef7fb2a and 8c8975d.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: cbcab4b6-c68e-4a07-9bd6-a8ead90748b9

📥 Commits

Reviewing files that changed from the base of the PR and between 14bf570 and ef7fb2a.

📒 Files selected for processing (3)

products/warehouse_sources/mcp/tools.yaml
services/mcp/schema/generated-tool-definitions.json
services/mcp/schema/tool-definitions-all.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Both destination tools now require the external_data_source:write scope instead of external_data_source:read. Their read-only annotations remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ef7fb

The destination tools now appear only to callers whose scopes let them invoke the endpoints. No actionable merge risk remains from this change.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to ef7fb

The change aligns tool availability with existing access requirements. It narrows availability without granting new permissions or weakening access controls.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The effective change is limited to eligibility for two project-scoped destination retrieval tools. Write-scoped callers already satisfied the previous read-scope gate, while read-only callers already lacked endpoint permission. The change therefore does not introduce a newly authorized caller class or mutation capability.

Trust Boundaries and Controls

observed — Tool scope filtering remains a discovery and registration control, while the API independently checks the forwarded credential against its action scope. Changing metadata does not grant permissions to the token or replace backend enforcement.

Hardening Proposals

proposed — A separate least-privilege change could distinguish GET from PATCH authorization, allowing destination retrieval with read scope while preserving write scope for updates. That would require coordinated backend enforcement and tool-metadata changes, rather than reverting this alignment alone.

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description explains the problem, scope changes, testing rationale, release status, and docs status. The Agent context omits the session link, skills used, CodeRabbit CLI status, and public-artifa…

✨ Finishing Touches 💡 1

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

webjunkie · 2026-10-05T12:09:10Z

@codex review

parameterai · 2026-10-05T12:09:14Z

Risk: No findings

This PR changes two warehouse-sources MCP tool entries in tools.yaml from external_data_source:read to external_data_source:write so the tool metadata matches what the API actually enforces. I verified the claim: both destinations actions (schema and source viewsets) are GET+PATCH actions listed in scope_object_write_actions with scope_object = "external_data_source", so :write is required even for the GET. The change is purely restrictive (fail-closed) — no security risk introduced.

_{Sentinel reviewed ef7fb2a · Review settings}

chatgpt-codex-connector · 2026-10-05T12:09:29Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-05T12:23:01.394326Z	`ef7fb2a`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-05T12:23:00Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: ef7fb2ad30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

A new stamphog review started for this PR — the fresh verdict replaces this approval.

stamphog

Approved.

This only corrects MCP tool scope metadata to match what the API already enforces (both destinations actions are write-scoped). It makes no runtime access change, and the declared scope can only get stricter.

👍 on the PR from chatgpt-codex-connector[bot].

Gate mechanics and policy version

Gate		Result
prerequisites	✓	all clear
deny-list	✓	no deny categories matched
size	✓	12L, 3F substantive — within ceiling
tier	✓	T0 auto-approve: T0-deterministic (12L, 3F, two-areas, fix)
stamphog 2.3.1		`.stamphog/policy.yml` @ `8c8975d` · reviewed head `8c8975d`

hosthog · 2026-10-05T14:51:59Z

HostHog preview — `posthog-desktop-web`

The previews for this PR have been torn down and no longer serve.

trunk-io · 2026-10-05T15:06:37Z

_{View Full Report ↗︎ ⋅ Docs}

deployment-status-posthog · 2026-10-05T16:52:07Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-05 16:51 UTC	Run
prod-us	✅ Deployed	2026-10-05 17:05 UTC	Run
prod-eu	✅ Deployed	2026-10-05 17:04 UTC	Run

webjunkie self-assigned this Oct 5, 2026

webjunkie changed the title ~~fix(warehouse_sources): align MCP tool scopes with the API~~ fix(warehouse-sources): align MCP tool scopes with the API Oct 5, 2026

webjunkie marked this pull request as ready for review October 5, 2026 12:09

webjunkie requested a review from a team October 5, 2026 12:09

webjunkie added the stamphog Request AI approval (no full review) label Oct 5, 2026

This comment was marked as outdated.

Sign in to view

webjunkie requested a review from a team October 5, 2026 14:12

Merge branch 'master' into fix/devex-mcp-scope-gaps-warehouse-sources

8c8975d

stamphog Bot approved these changes Oct 5, 2026

View reviewed changes

rnegron approved these changes Oct 5, 2026

View reviewed changes

trunk-io Bot merged commit e1b2b54 into master Oct 5, 2026

trunk-io Bot deleted the fix/devex-mcp-scope-gaps-warehouse-sources branch October 5, 2026 16:23

Conversation

webjunkie commented Oct 5, 2026

Problem

Changes

How did you test this code?

Release status

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

posthog Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦔 PostHog Review reviewed this pull request

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

coderabbitai Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Security Architecture Review

Uh oh!

webjunkie commented Oct 5, 2026

Uh oh!

parameterai Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 5, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

hosthog Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

HostHog preview — posthog-desktop-web

Uh oh!

trunk-io Bot commented Oct 5, 2026

Uh oh!

deployment-status-posthog Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trunk-io Bot commented Oct 5, 2026 •

edited

Loading

posthog Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading

parameterai Bot commented Oct 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 5, 2026 •

edited

Loading

hosthog Bot commented Oct 5, 2026 •

edited

Loading

HostHog preview — `posthog-desktop-web`

deployment-status-posthog Bot commented Oct 5, 2026 •

edited

Loading